-
Notifications
You must be signed in to change notification settings - Fork 4
Fix flutter segment #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 76.42% 75.40% -1.03%
==========================================
Files 61 61
Lines 2401 2403 +2
==========================================
- Hits 1835 1812 -23
- Misses 566 591 +25
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue with the Flutter segment tracking functionality by ensuring persona values are converted to strings before being sent to the API. It also adds error handling for exposure encoding and updates the development environment configuration.
- Converts all persona values to strings in segment tracking to prevent type serialization issues
- Adds try-catch block around exposure object encoding to handle potential JSON encoding errors gracefully
- Updates iOS deployment target from 12.0 to 13.0 and upgrades Android Gradle wrapper to 8.7
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/hits/segment.dart | Converts persona map values to strings to ensure proper serialization in segment tracking |
| lib/visitor/strategy/default_strategy.dart | Adds error handling for exposure flag and visitor encoding failures |
| example/lib/Providers/fs_data.dart | Adds test context data with various data types including a null value |
| example/ios/Podfile | Updates iOS platform version from 12.0 to 13.0 |
| example/ios/Runner.xcodeproj/project.pbxproj | Updates IPHONEOS_DEPLOYMENT_TARGET to 13.0 across all build configurations |
| example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme | Adds LLDB initialization file configuration and GPU validation mode |
| example/ios/Flutter/AppFrameworkInfo.plist | Updates MinimumOSVersion to 13.0 |
| example/ios/Podfile.lock | Updates Flutter and podfile checksums after dependency changes |
| example/ios/Flutter/ephemeral/flutter_lldbinit | Adds Flutter LLDB initialization file (generated) |
| example/ios/Flutter/ephemeral/flutter_lldb_helper.py | Adds Python helper script for LLDB integration with RX pages |
| example/android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle version from 8.0 to 8.7 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…lutter-sdk into fixFlutterSegment
|



No description provided.